Skip to content

Reject nonfinite association weights#2285

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-main-codebase-bug-3
May 27, 2026
Merged

Reject nonfinite association weights#2285
FlorianPfaff merged 2 commits into
mainfrom
fix-main-codebase-bug-3

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Reject non-finite sample_weight values before fitting LogisticPairwiseAssociationModel.
  • Reject non-finite class-weight dictionary entries.
  • Add regression coverage for NaN, inf, and -inf weights.

Root Cause

The association model validated negative weights, but NaN and positive infinity pass comparisons like weight <= 0.0. Those values could enter the effective weights and poison the Newton system with non-finite gradients or Hessians instead of failing clearly at input validation.

Validation

  • py -3.12 -m pytest -q tests\test_association_models.py
  • py -3.12 -m ruff check src tests
  • git diff --check

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 12:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 33.91s
✅ JSON prettier 7 0 0 0 0.87s
✅ JSON v8r 7 0 0 4.52s
✅ MARKDOWN markdownlint 66 0 0 0 1.77s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.8s
✅ PYTHON black 771 2 0 0 33.41s
✅ PYTHON isort 771 2 0 0 2.12s
✅ REPOSITORY checkov yes no no 40.04s
✅ REPOSITORY gitleaks yes no no 15.2s
✅ REPOSITORY git_diff yes no no 0.09s
✅ REPOSITORY secretlint yes no no 22.89s
✅ REPOSITORY syft yes no no 7.84s
✅ REPOSITORY trivy-sbom yes no no 4.5s
✅ REPOSITORY trufflehog yes no no 20.65s
✅ YAML prettier 11 0 0 0 0.67s
✅ YAML v8r 11 0 0 10.83s
✅ YAML yamllint 11 0 0 0.45s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit e347e91 into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant