Skip to content

Validate candidate pruning top-k#2294

Merged
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-10
May 27, 2026
Merged

Validate candidate pruning top-k#2294
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-10

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • reject boolean, fractional, non-finite, and shaped-array values for candidate pruning row_top_k and column_top_k
  • keep scalar integer-like top-k values accepted through config normalization
  • add regression coverage for invalid top-k inputs

Root cause

CandidatePruningConfig normalized top-k values with bare int(...), so inputs such as True and 1.5 were silently converted to 1. That can change the pruning graph while appearing to be a valid configuration.

Tests

  • py -3.12 -m pytest -q tests\test_candidate_pruning.py
  • py -3.12 -m ruff check src tests
  • git diff --check
  • git diff --cached --check

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 12:56
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 50.71s
✅ JSON prettier 7 0 0 0 1.1s
✅ JSON v8r 7 0 0 4.68s
✅ MARKDOWN markdownlint 66 0 0 0 1.72s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.7s
✅ PYTHON black 771 2 0 0 39.28s
✅ PYTHON isort 771 2 0 0 2.34s
✅ REPOSITORY checkov yes no no 45.55s
✅ REPOSITORY gitleaks yes no no 16.85s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 23.18s
✅ REPOSITORY syft yes no no 4.25s
✅ REPOSITORY trivy-sbom yes no no 6.25s
✅ REPOSITORY trufflehog yes no no 22.62s
✅ YAML prettier 11 0 0 0 0.66s
✅ YAML v8r 11 0 0 12.29s
✅ YAML yamllint 11 0 0 0.62s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 4ffac9f into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant