Skip to content

Validate linear update planning scalars#2296

Merged
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-12
May 27, 2026
Merged

Validate linear update planning scalars#2296
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-12

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • validate linear-update planning scalar inputs before comparisons and robust scale calculations
  • reject NaN/inf, booleans, non-scalar arrays, and fractional measurement dimensions in gating and robust update helpers
  • add regression coverage for invalid gate thresholds, measurement dimensions, robust scaling inputs, and Student-t degrees of freedom

Root cause

Several public helpers used bare float(...)/int(...) conversion and positivity checks. NaN values pass <= 0 checks by making comparisons false, and fractional or boolean dimensions could be coerced into valid-looking chi-square degrees of freedom.

Tests

  • py -3.12 -m pytest -q tests\filters\test_linear_update_planning.py tests\test_linear_gaussian_robust.py tests\filters\test_robust_linear_gaussian_update.py
  • py -3.12 -m ruff check src tests
  • git diff --check
  • git diff --cached --check

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 13:08
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 44.85s
✅ JSON prettier 7 0 0 0 1.05s
✅ JSON v8r 7 0 0 6.15s
✅ MARKDOWN markdownlint 66 0 0 0 1.74s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.99s
✅ PYTHON black 771 0 0 0 40.61s
✅ PYTHON isort 771 1 0 0 6.67s
✅ REPOSITORY checkov yes no no 46.54s
✅ REPOSITORY gitleaks yes no no 12.52s
✅ REPOSITORY git_diff yes no no 0.15s
✅ REPOSITORY secretlint yes no no 22.12s
✅ REPOSITORY syft yes no no 4.72s
✅ REPOSITORY trivy-sbom yes no no 7.87s
✅ REPOSITORY trufflehog yes no no 21.79s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 10.97s
✅ YAML yamllint 11 0 0 0.58s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit fa00405 into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant