Skip to content

Fix raw PyTorch clip under non-PyTorch backends#3433

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-raw-pytorch-clip-default-backend
Jun 29, 2026
Merged

Fix raw PyTorch clip under non-PyTorch backends#3433
FlorianPfaff merged 2 commits into
mainfrom
fix-raw-pytorch-clip-default-backend

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Patch pyrecest.backend_support so raw pyrecest._backend.pytorch.clip accepts NumPy-style array-like inputs even when the active public backend is not PyTorch.
  • Preserve a_min/a_max, min/max, and out= handling while updating the active public PyTorch facade when applicable.
  • Add a subprocess regression test for PYRECEST_BACKEND=numpy with direct raw PyTorch clip access.

Bug fixed

With the default/NumPy public backend, importing pyrecest did not apply the PyTorch clip wrapper because the existing facade patch returns early unless PYRECEST_BACKEND=pytorch. Direct calls such as pyrecest._backend.pytorch.clip([-2.0, 0.5, 3.0], -1.0, 2.0) therefore reached torch.clip with a Python list and failed before backend conversion.

Testing

  • Added tests/backend_support/test_pytorch_clip_default_backend.py.
  • Sanity-checked the wrapper behavior locally against the installed torch package; full repository tests were not run in this connector session.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 29, 2026 14:24
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 74.45s
✅ JSON prettier 7 0 0 0 1.04s
✅ JSON v8r 7 0 0 5.27s
✅ MARKDOWN markdownlint 68 0 0 0 2.06s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.71s
✅ PYTHON black 1126 10 0 0 61.69s
✅ PYTHON isort 1126 15 0 0 2.97s
✅ REPOSITORY checkov yes no no 48.53s
✅ REPOSITORY gitleaks yes no no 11.45s
✅ REPOSITORY git_diff yes no no 0.1s
✅ REPOSITORY secretlint yes no no 42.28s
✅ REPOSITORY syft yes no no 4.66s
✅ REPOSITORY trivy-sbom yes no no 7.6s
✅ REPOSITORY trufflehog yes no no 17.59s
✅ YAML prettier 11 0 0 0 0.82s
✅ YAML v8r 11 0 0 12.18s
✅ YAML yamllint 11 0 0 0.67s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff force-pushed the fix-raw-pytorch-clip-default-backend branch from 49a6ea8 to 4d7f60c Compare June 29, 2026 15:31
@FlorianPfaff FlorianPfaff merged commit eabd1bb into main Jun 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant