Skip to content

[Brutal Review] 12 potential resource leaks #335

@sfloess

Description

@sfloess

Severity: HIGH

Found 12 resource allocations not using try-with-resources.

Impact: Memory leaks, file handle exhaustion.

Sample findings:

=== Potential Resource Leaks (no try-with-resources) ===
src/main/java/org/flossware/classloader/RemoteClassSource.java:127:                     ByteArrayOutputStream out = new ByteArrayOutputStream(initialSize)) {
src/main/java/org/flossware/classloader/RestApiClassSource.java:69:        HttpURLConnection connection = (HttpURLConnection) new URL(url).openConnection();
src/main/java/org/flossware/classloader/RestApiClassSource.java:91:                 ByteArrayOutputStream out = new ByteArrayOutputStream()) {
src/main/java/org/flossware/classloader/RestApiClassSource.java:135:            HttpURLConnection connection = (HttpURLConnection) new URL(url).openConnection();
src/main/java/org/flossware/classloader/MavenRepositoryClassSource.java:174:             JarInputStream jarIn = new JarInputStream(in)) {
src/main/java/org/flossware/classloader/MavenRepositoryClassSource.java:188:                    ByteArrayOutputStream out = new ByteArrayOutputStream();
src/main/java/org/flossware/classloader/MavenNexusClassSource.java:180:             JarInputStream jarIn = new JarInputStream(in)) {
src/main/java/org/flossware/classloader/MavenNexusClassSource.java:194:                    ByteArrayOutputStream out = new ByteArrayOutputStream();
src/main/java/org/flossware/classloader/NexusClassSource.java:170:             ByteArrayOutputStream out = new ByteArrayOutputStream()) {

Action Required: Use try-with-resources for AutoCloseable resources.


Generated by brutal code review on 2026-05-29 21:24:33

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality and maintainability issues

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions