Skip to content

[Brutal Review] 31 overly broad exception catches #336

@sfloess

Description

@sfloess

Severity: MEDIUM

Found 31 catch blocks catching generic Exception/Throwable.

Impact: Hides bugs, catches errors that shouldn't be caught.

Sample findings:

=== Catching Generic Exceptions ===
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:58:        } catch (MinioException e) {
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:60:        } catch (Exception e) {
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:90:        } catch (MinioException e) {
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:92:        } catch (Exception e) {
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:110:        } catch (Exception e) {
src/main/java/org/flossware/classloader/delegation/CustomDelegation.java:37:            } catch (ClassNotFoundException e) {
src/main/java/org/flossware/classloader/delegation/CustomDelegation.java:44:            } catch (ClassNotFoundException e) {
src/main/java/org/flossware/classloader/delegation/ParentFirstDelegation.java:20:        } catch (ClassNotFoundException e) {
src/main/java/org/flossware/classloader/delegation/ParentLastDelegation.java:62:        } catch (ClassNotFoundException e) {
src/main/java/org/flossware/classloader/lifecycle/ResourceTrackingListener.java:82:            } catch (Exception e) {
src/main/java/org/flossware/classloader/util/ClassLoaderCleanupUtil.java:100:        } catch (Exception e) {
src/main/java/org/flossware/classloader/util/ClassLoaderCleanupUtil.java:149:        } catch (Exception e) {
src/main/java/org/flossware/classloader/util/ClassLoaderCleanupUtil.java:183:        } catch (Exception e) {
src/main/java/org/flossware/classloader/util/ClassLoaderCleanupUtil.java:207:                    } catch (Exception e) {

Action Required: Catch specific exception types.


Generated by brutal code review on 2026-05-29 21:24:35

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality and maintainability issues

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions