Skip to content

[Brutal Review] 83 deeply nested statements (>3 levels) #341

@sfloess

Description

@sfloess

Severity: MEDIUM

Found 83 statements with excessive nesting.

Impact: Hard to read, test, and maintain. High cyclomatic complexity.

Sample findings:

=== Deep Nesting (>3 levels) ===
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:60:4 levels:                // Validate file size before loading to prevent OutOfMemoryError
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:62:4 levels:                if (fileSize > MAX_CLASS_FILE_SIZE) {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:64:5 levels:                    // Delete it and return null to force re-fetch from source
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:125:5 levels:                    // Sort by depth (deepest first) to delete files before directories
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:127:6.25 levels:                         .forEach(path -> {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:138:4 levels:                if (!errors.isEmpty()) {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:142:5 levels:                    errors.forEach(exception::addSuppressed);
src/main/java/org/flossware/classloader/filesystem/HdfsClassSource.java:65:4 levels:                if (n == -1) break;
src/main/java/org/flossware/classloader/objectstore/MinioClassSource.java:84:4 levels:                if (n == -1) break;

Action Required: Extract methods, use guard clauses, reduce nesting.


Generated by brutal code review on 2026-05-29 21:25:02

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality and maintainability issues

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions