Code Quality: i18n infrastructure exists but is completely unused (dead code)

[sfloess]

Description

Complete i18n infrastructure was added (Messages.java, resource bundles for 4 languages) but is never actually used anywhere in the codebase. All UI strings remain hardcoded.

Files Added But Unused

Java infrastructure:

• src/main/java/org/flossware/jnexus/Messages.java (150+ lines)

Resource bundles (4 languages):

• src/main/resources/messages.properties (English)
• src/main/resources/messages_de.properties (German)
• src/main/resources/messages_es.properties (Spanish)
• src/main/resources/messages_fr.properties (French)

Evidence of Non-Usage

No imports:

$ grep -r "import.*Messages" src/main/java --include="*.java"
# No results (Messages.java only imports itself)

No method calls:

$ grep -n "Messages\.get\|Messages\.format" src/main/java/*.java
# Only 2 results - both are example comments in Messages.java itself

UI still hardcoded:

// JNexusSwing.java - all strings hardcoded
JButton listButton = new JButton("List");
JButton refreshButton = new JButton("Refresh");
JButton deleteButton = new JButton("Delete");
// Should be:
// JButton listButton = new JButton(Messages.get("button.list"));

Git History

commit 30dad6d
feat: Add i18n/l10n foundation with English resource bundle - Partial #45

Marked as "Partial" but no follow-up commits to actually integrate it.

Impact

• Code bloat: ~350 lines of unused code across 5 files
• Maintenance burden: Files that need updating but serve no purpose
• Confusion: Developers think i18n is implemented when it's not
• Issue Documentation: No i18n/l10n support - all UI text is English-only #45 still open: Despite infrastructure, no actual i18n support

Options

Option 1: Complete the implementation (recommended)

• Update all UI code to use Messages.get()/Messages.format()
• Replace hardcoded strings with keys
• Test language switching
• Close issue Documentation: No i18n/l10n support - all UI text is English-only #45

Option 2: Remove dead code

• Delete Messages.java
• Delete all messages*.properties files
• Keep issue Documentation: No i18n/l10n support - all UI text is English-only #45 open
• Add TODO for future i18n work

Option 3: Document as in-progress

• Add JavaDoc to Messages.java explaining it's not yet integrated
• Add TODO comments in UI code where Messages should be used
• Keep infrastructure for easier future implementation

Recommendation

Complete the implementation or remove it. Half-done features create technical debt.

Related

• Issue Documentation: No i18n/l10n support - all UI text is English-only #45: Documentation says no i18n/l10n support (still accurate despite infrastructure existing)

[sfloess]

Fixed in commit. Removed all unused i18n infrastructure:

• Messages.java (100 lines)
• messages*.properties files (4 files, 100+ keys each)
• MessagesTest.java (152 lines, 12 tests)

Total: 6 files deleted, 292 tests passing (down from 304). If i18n is needed in future, will re-implement with actual UI integration.