Removed and replaced SHM-jemalloc Arena::construct<T>(bool use_cache, ...) overload API due to potential overload ambiguity for some Ts. / Ipc_arena public super-class Shm_pool_collection also has a construct() with potentially ambiguous signature; renamed to construct_maybe_thread_cached(). / Comment and/or doc changes.#131
Merged
Removed and replaced SHM-jemalloc Arena::construct<T>(bool use_cache, ...) overload API due to potential overload ambiguity for some Ts. / Ipc_arena public super-class Shm_pool_collection also has a construct() with potentially ambiguous signature; renamed to construct_maybe_thread_cached(). / Comment and/or doc changes.#131
Arena::construct<T>(bool use_cache, ...) overload API due to potential overload ambiguity for some Ts. / Ipc_arena public super-class Shm_pool_collection also has a construct() with potentially ambiguous signature; renamed to construct_maybe_thread_cached(). / Comment and/or doc changes.#131Conversation
…/ Removed and replaced SHM-jemalloc `Arena::construct<T>(bool use_cache, ...)` overload API due to potential overload ambiguity for some `T`s. (Impl: It has become private `construct_impl()`; `construct(args...)` continues to call `construct_impl(false, ...)`, as it was calling the deleted overload before. New API `construct_thread_cached()` calls `construct_impl(true, ...)`.)
…ass also has a construct() with potentially ambiguous signature; renamed to construct_maybe_thread_cached().>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Flow-IPC/ipc_shm_arena_lend#56
API notes (ATTN when writing release notes):
ipc::shm::arena_lend::jemalloc::Ipc_arena::construct_thread_cached(): replaces removedconstruct(true, ...).ipc::shm::arena_lend::jemalloc::Shm_pool_collection::construct_maybe_thread_cached(): replaces removedconstruct().ipc::shm::arena_lend::jemalloc::Ipc_arena::construct(bool use_cache).use_cache = true, callconstruct_thread_cached()(new).use_cache = false, callconstruct(Ctor_args&&... args).ipc::shm::arena_lend::jemalloc::Shm_pool_collection::construct()tomaybe_thread_caching().Impl notes:
construct(bool, ...)has become privateconstruct_impl();construct(args...)continues to callconstruct_impl(false, ...), as it was calling the deleted overload before. New APIconstruct_thread_cached()callsconstruct_impl(true, ...).To code reviewer:
Forgoing code review, as the change is in ipc_shm_arena_lend repo (submodule) and has been reviewed/merged.