Move Old HttpWebRequest to HttpClient Instance #172
Conversation
Release 1.1.0 | Plugin 1.1.0 | Explorer Plugin 1.1.0
Release 1.1.1
Release 1.1.2
Release 1.2.0 | Plugin 1.2.0
Release 1.2.1
|
Hey I just saw the PR is going against Master. Can you change the base to Dev instead please, you can do this by clicking on 'Edit'. We develop against the Dev branch.
|
Release 1.3.0 | Plugin 1.2.1
|
Yes, thank you for telling me that I can do this. |
|
Hey @taooceros , it would be better to separate out the two change set please, otherwise one may delay the other due to review/discussion. Let me know if you need help to do this. Once the improvements from bao-qian is in separate pr, i can review it, as I have a few questions about the change set such as why remove translate as it sets the future use for translating other languages, and that particular line removed is currently used to translate user's Chinese into Pinyin so the string matcher can compare. |
|
Sorry, I do want to separate them into two branches... . However, it seems that they have automatically merge each other. I will take a look on them and try to seperate them into two pull requests later. |
taooceros
force-pushed
the
master
branch
2 times, most recently
from
424d757 to
135f63a
Compare
Master 1.3.0
|
I will create a new pull request from another branch regarding that this pull request is based on the master branch, while I would like to keep it the same as the main repository of Flow. |
2 participants
No description provided.