-
-
Notifications
You must be signed in to change notification settings - Fork 453
Pinyin improvement (Merge from Wox) #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release 1.1.0 | Plugin 1.1.0 | Explorer Plugin 1.1.0
Release 1.1.1
Release 1.1.2
Release 1.2.0 | Plugin 1.2.0
Release 1.2.1
Release 1.3.0 | Plugin 1.2.1
Master 1.3.0
This reverts commit eefe210.
|
Hey how's it going. Do we know the advantages of the new library over the current? Are there benefits aside from faster loading time?
Is there a way we can test this just to be sure? |
|
Sounds like an awesome change if query time and memory utilisation with pinyin search is less. let me know when PR is ready for review. |
|
Also sorry i forgot to mention, if we are reusing code from Wox, lets attribute the commits to the authors that wrote it please. |
|
Sure, could you please tell me how I should do that? |
yeah so when you commit the changes use this to indicate the author, you can find his email on his profile page. Also please let's not write the commit message 'code from Wox', but rather describe the changes as usual. Apologies if this makes you have to re-PR |
|
Let me take a try on a new branch |
|
you need to keep the angle brackets <> git commit --author="John blah <JohnBlah@someemail.com>" -m "YOUR MESSAGE THAT DESCRIBES THE COMMIT" |
|
Done it and created a new pull request #183 |


Wox has changed the Pinyin Library to ToolGood.Words. #2962 Thank you for the change @bao-qian .
This pull request has done the same thing, but optimize a few.
I have checked the previous cache storage and it actually makes the loading time quite long, so I remove the Save and Loading cache in this pull request because it seems that the library is fast enough.