Skip to content

Fix incorrect Everything dll import name#4371

Merged
VictoriousRaptor merged 1 commit intodevfrom
VictoriousRaptor-patch-1
Mar 22, 2026
Merged

Fix incorrect Everything dll import name#4371
VictoriousRaptor merged 1 commit intodevfrom
VictoriousRaptor-patch-1

Conversation

@VictoriousRaptor
Copy link
Copy Markdown
Contributor

@VictoriousRaptor VictoriousRaptor commented Mar 21, 2026

Summary by cubic

Fixes a mismatched P/Invoke by replacing a hard-coded import with the shared DLL constant, ensuring the correct Everything DLL loads across architectures and preventing runtime load errors.

Summary of changes

  • Changed: Swapped [DllImport("Everything64.dll"...)] for [DllImport(DLL,...)] on Everything_GetResultExtension to use the centralized DLL name.
  • Added: No new logic or behavior.
  • Removed: The hard-coded DLL name for this API entry point.
  • Memory impact: None.
  • Security risks: None; using a centralized DLL reference reduces risk of loading the wrong architecture.
  • Unit tests: No new tests added. Existing behavior covered by integration/runtime verification.

Written for commit 56c32ad. Summary will update on new commits.

@VictoriousRaptor VictoriousRaptor self-assigned this Mar 21, 2026
@VictoriousRaptor VictoriousRaptor added the bug Something isn't working label Mar 21, 2026
@VictoriousRaptor VictoriousRaptor enabled auto-merge (squash) March 21, 2026 17:10
@github-actions github-actions Bot added this to the 2.2.0 milestone Mar 21, 2026
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm Bot commented Mar 21, 2026

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs

Activity based on git-commit:

Jack251970
MAR
FEB
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 100%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm Bot commented Mar 21, 2026

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e73a30b-6176-4955-9b01-381723d465c4

📥 Commits

Reviewing files that changed from the base of the PR and between 2bd6e9a and 56c32ad.

📒 Files selected for processing (1)
  • Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs

📝 Walkthrough

Walkthrough

A P/Invoke declaration in the Everything API integration was updated to use a DLL constant instead of a hardcoded string for the DLL import target, changing from "Everything64.dll" to the constant value "Everything.dll".

Changes

Cohort / File(s) Summary
P/Invoke DLL Import Constant
Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs
Updated Everything_GetResultExtension method's DllImport attribute to reference the DLL constant instead of hardcoded "Everything64.dll" string literal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing an incorrect DLL import name by replacing a hard-coded DLL reference with a constant.
Description check ✅ Passed The description is well-related to the changeset, explaining the fix, its purpose, and impacts. It provides meaningful context about the P/Invoke change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch VictoriousRaptor-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@VictoriousRaptor VictoriousRaptor merged commit d51a496 into dev Mar 22, 2026
14 checks passed
@VictoriousRaptor VictoriousRaptor deleted the VictoriousRaptor-patch-1 branch March 22, 2026 05:29
@jjw24 jjw24 changed the title Fix incorrect dll import name Fix incorrect Everything dll import name Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants