Fix highlight data 0 length

[VictoriousRaptor]

Follow #4196

---

Summary by cubic

Fixes missing title highlights when an empty highlight data list is passed by falling back to fuzzy search match data. Applies to both folder and file results to keep highlighting consistent.

• Summary of changes
  • Changed: TitleHighlightData now falls back to Context.API.FuzzySearch(query.Search, title).MatchData when highlightData is null or has length 0 in CreateFolderResult and CreateFileResult.
  • Added: Explicit zero-length check for highlightData to trigger the fallback.
  • Removed: Passing through empty highlightData, which produced no highlights.
  • Memory: Negligible impact; only allocates match data when highlightData is empty.
  • Security: No risks; UI-only change affecting result highlighting.
  • Tests: No unit tests added; consider tests for null and empty highlightData.

^{Written for commit d03b698. Summary will update on new commits.}

[gitstream-cm]

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs

Activity based on git-commit:

	Jack251970
MAR	45 additions & 0 deletions
FEB
JAN
DEC
NOV
OCT	420 additions & 0 deletions

Knowledge based on git-blame:
Jack251970: 98%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[cubic-dev-ai]

No issues found across 1 file

[coderabbitai]

📝 Walkthrough

Walkthrough

The change adds an additional validation condition when assigning TitleHighlightData in folder and file result creation methods. Instead of using provided highlight data only when non-null, the code now additionally checks that the highlight data collection is non-empty before using it, otherwise falling back to fuzzy-search results.

Changes

Cohort / File(s)	Summary
ResultManager Highlight Data Validation Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs	Added non-empty collection check to highlight data validation in CreateFolderResult and CreateFileResult methods; provided highlight data is now used only when both non-null and containing elements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Use Highlight matches from Everything  #4196: Related change to ResultManager.cs that modifies highlight data handling for file and folder result creation with similar validation logic.

Suggested reviewers

• jjw24
• Jack251970

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: fixing the handling of highlight data with zero length.
Description check	✅ Passed	The PR description clearly explains the changeset: fixing missing title highlights when empty highlight data is passed by falling back to fuzzy search, with specific details about affected methods and behavior changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-highlightdata-0-len

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}