issue 3108 first attempt splitting KeyStore.getFirst #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@danishnavid008 please merge changes from master to here, and help me finish this PR. Thanks! |
Contributor
|
@tomholub This PR is ready for review |
tomholub
commented
Dec 10, 2020
Collaborator
Author
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
I see one error - please have a look. Have you evaluated all usages of getFirstRequired vs getFirstOptional? Are there no situations when you're unsure and would want to double check with me?
tomholub
commented
Dec 11, 2020
Collaborator
Author
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
It looks good now - there is one remaining line that maybe was added by mistake.
Maybe earlier I was reviewing an older version - not sure. Thanks!
Collaborator
Author
|
All good, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3108