#5318 Add ConfiguredIdPOAuth class #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@sosnovsky this is for milestone 8.5.2 but I think this is ready for review. thank you! |
Collaborator
|
@martgil is this one ready for review or it's a draft? |
Collaborator
Author
sorry, not yet. I'm just wondering if this could be leave as is one approved without it getting merged? |
Collaborator
Author
|
@sosnovsky Ready for review. (not ready to merge -- waiting for milestone 4.5.1 official release) thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds a new class called 'ConfiguredIdPOAuth' and a test for ensuring its effective implementation.
close #5318
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):