#5896 Propose hotfix in extension when sending password messages

[martgil]

This PR proposed a hotfix in the FlowCrypt browser extension for an issue that exists when sending password messages.

close #5896

---

Tests (delete all except exactly one):

• Does not need tests (refactor only, docs or internal changes)

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[martgil]

Hello @sosnovsky - please kindly check if this hotfix looks good to you. I'll be sending the screen recording via email. Thanks!

[sosnovsky]

current solution affects all sent messages, while issue happens only for password-protected messages with accented characters in recipient name.
let's apply fix only for such cases.

in webPortalMessageUpload we use formatEmailWithOptionalName method for formatting recipient emails before uploading message. there we can also transform accented characters to their non-accented versions (Š will become S, ř -> r etc).

then implemented solution won't affect other messages and make it possible to send password-protected messages to all recipients.

[martgil]

current solution affects all sent messages, while issue happens only for password-protected messages with accented characters in recipient name. let's apply fix only for such cases.

in webPortalMessageUpload we use formatEmailWithOptionalName method for formatting recipient emails before uploading message. there we can also transform accented characters to their non-accented versions (Š will become S, ř -> r etc).

then implemented solution won't affect other messages and make it possible to send password-protected messages to all recipients.

You’re right. I’ve followed your instructions, and this has helped me improve in providing a fix. Unfortunately, adding a test doesn’t seem feasible since the transformation of text only occurs and becomes visible right when the request is sent. I verified the fix by inspecting the request sent by the browser extension to shared-tenant-fes. Indeed, my changes correctly replace accented characters with their non-accented versions.

One can verify this change by adding a recipient on contacts.google.com with accented characters. Then, send a password-protected message to them using the extension while monitoring the network traffic. Specifically, watch the request sent to shared-tenant-fes, more precisely to POST https://flowcrypt.com/shared-tenant-fes/api/v1/message.

[martgil]

@sosnovsky This one is ready for a review again. I've also manually tested this and it works as it should. The accented characters where being replaced leads to 200 OK when sending the upload to FES.

[sosnovsky]

Nice temporary fix 👍

[martgil]

Yes, it wouldn't be possible without your help. thank you, too.