Ensure npmrc is encrypted before pushing to github#5898
Merged
Conversation
fixes #5658 Ensures that the .npmrc file is encrypted when pushed to GitHub and decrypted (if required) when pulled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5898 +/- ##
==========================================
- Coverage 76.51% 76.48% -0.03%
==========================================
Files 369 369
Lines 17994 18001 +7
Branches 4194 4197 +3
==========================================
Hits 13768 13768
- Misses 4226 4233 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Steve-Mcl
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5658
Description
Ensures that the .npmrc file is encrypted when pushed to GitHub and decrypted (if required) when pulled.
This needs to happen because if GH spots a npm token being checked in it rejects the push to prevent leaking tokens in public repos.
I can't find any existing tests for the gitops stuff and since it's limited to only working with github hosted repos I can't see how to test this without having to add a user token to the tests. If I could bypass the github requirement I could create a local directory git repo to test with.
Tagging @Steve-Mcl rather than Nick as he has enough to do today before he heads out.
Related Issue(s)
#5658
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel