Skip to content

Allow Devices to get FF Tables creds#5921

Merged
Steve-Mcl merged 3 commits into
mainfrom
device-access-to-ff-tables
Aug 15, 2025
Merged

Allow Devices to get FF Tables creds#5921
Steve-Mcl merged 3 commits into
mainfrom
device-access-to-ff-tables

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

fixes #5920

Description

Adds Device tokens to the allowed list for FF Tables creds.

Related Issue(s)

#5920

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from Steve-Mcl August 15, 2025 09:25
@hardillb hardillb self-assigned this Aug 15, 2025
Comment thread test/unit/forge/ee/routes/tables/index_spec.js Outdated
@Steve-Mcl Steve-Mcl self-requested a review August 15, 2025 09:27
Copy link
Copy Markdown
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just waiting tests.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.50%. Comparing base (2448555) to head (d665857).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/tables/index.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5921      +/-   ##
==========================================
+ Coverage   76.49%   76.50%   +0.01%     
==========================================
  Files         370      370              
  Lines       18078    18082       +4     
  Branches     4222     4224       +2     
==========================================
+ Hits        13829    13834       +5     
+ Misses       4249     4248       -1     
Flag Coverage Δ
backend 76.50% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/unit/forge/ee/routes/tables/index_spec.js Outdated
Comment thread test/unit/forge/ee/routes/tables/index_spec.js Outdated
@Steve-Mcl Steve-Mcl merged commit dcaa76b into main Aug 15, 2025
26 of 27 checks passed
@Steve-Mcl Steve-Mcl deleted the device-access-to-ff-tables branch August 15, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FF Tables endpoint needs to allow devices as well as instances

2 participants