fix(housekeeper): add optional chaining for broker availability check #6311
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The housekeeper leadership voting feature introduced in PR #6239 assumes the MQTT broker is always configured. This causes a crash when running FlowFuse without broker configuration (which is valid for local dev). Add optional chaining to safely handle cases where app.comms.platform is undefined, consistent with how other parts of the codebase handle missing broker configuration (e.g., forge/settings/index.js).
Contributor
Author
|
@hardillb can you see if this makes sense according to you for dev usecases? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
=======================================
Coverage 76.61% 76.61%
=======================================
Files 387 387
Lines 19582 19582
Branches 4707 4707
=======================================
Hits 15003 15003
Misses 4579 4579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hardillb
approved these changes
Nov 19, 2025
Contributor
|
@dimitrieh running with a broker locally is probably worth it as a lot of the EE features now depend on it, but this should allow housekeeper tasks to run without. |
Contributor
Author
|
@hardillb 👍 . merging in that case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The housekeeper leadership voting feature introduced in PR #6239 assumes the MQTT broker is always configured. This causes a crash when running FlowFuse without broker configuration (which is valid for local dev).
Add optional chaining to safely handle cases where app.comms.platform is undefined, consistent with how other parts of the codebase handle missing broker configuration (e.g., forge/settings/index.js).
Related Issue(s)
No issue as of yet. But the change was necessary due to #6239
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel