Skip to content

Conversation

@knolleary
Copy link
Member

@knolleary knolleary commented Jan 9, 2026

Part of #6484

Currently, the google social login flow will always automatically create a new user if they are logging in for the first time.

If we disable self-service sign-up of the app, we also need to prevent the social login from provisioning new users.

This adds a new admin option for the social login as to whether new users should be created when attempting to login for the first time.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.41%. Comparing base (01cfe8a) to head (819eb11).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/sso/social/google.js 0.00% 2 Missing ⚠️
forge/routes/api/settings.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6485      +/-   ##
==========================================
- Coverage   76.42%   76.41%   -0.02%     
==========================================
  Files         396      396              
  Lines       19885    19888       +3     
  Branches     4766     4767       +1     
==========================================
  Hits        15198    15198              
- Misses       4687     4690       +3     
Flag Coverage Δ
backend 76.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns
Copy link
Contributor

cstns commented Jan 12, 2026

Should we "link" this platform option to the existing Allow new users to register on the login screen option and offer the possibility of enablement only if the first option is also enabled?

I assume this is mostly intended for FFC so not sure how much we want to complicate things or if a change request to enable is required.

@knolleary
Copy link
Member Author

Lets not complicate it for now. We're the only ones using these options.

@knolleary knolleary merged commit 6fcab5c into main Jan 13, 2026
32 of 34 checks passed
@knolleary knolleary deleted the google-auto-create branch January 13, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants