Skip to content

Fix Expert errors when device are present in MCPRegistrations#6584

Merged
Steve-Mcl merged 1 commit intomainfrom
6583_fix-mcp-registration-relation-key
Jan 28, 2026
Merged

Fix Expert errors when device are present in MCPRegistrations#6584
Steve-Mcl merged 1 commit intomainfrom
6583_fix-mcp-registration-relation-key

Conversation

@cstns
Copy link
Copy Markdown
Contributor

@cstns cstns commented Jan 28, 2026

Description

  • Handle device id inconsistency when upserting MCPRegistations table.
  • don't query live state for devices when retrieving features

Related Issue(s)

closes #6583

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from hardillb January 28, 2026 13:40
@cstns cstns self-assigned this Jan 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.61%. Comparing base (8e3b5b3) to head (1fb1965).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/mcp/index.js 33.33% 4 Missing ⚠️
forge/routes/api/expert.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6584      +/-   ##
==========================================
- Coverage   76.62%   76.61%   -0.02%     
==========================================
  Files         398      398              
  Lines       20093    20100       +7     
  Branches     4836     4839       +3     
==========================================
+ Hits        15397    15400       +3     
- Misses       4696     4700       +4     
Flag Coverage Δ
backend 76.61% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Steve-Mcl Steve-Mcl merged commit 4bef29b into main Jan 28, 2026
32 of 34 checks passed
@Steve-Mcl Steve-Mcl deleted the 6583_fix-mcp-registration-relation-key branch January 28, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error accessing Expert on FFC

3 participants