Skip to content

Use correct favicon and use provided link to package#6678

Merged
Steve-Mcl merged 3 commits intomainfrom
6669-wrong-url-and-favicon
Feb 10, 2026
Merged

Use correct favicon and use provided link to package#6678
Steve-Mcl merged 3 commits intomainfrom
6669-wrong-url-and-favicon

Conversation

@Steve-Mcl
Copy link
Copy Markdown
Contributor

@Steve-Mcl Steve-Mcl commented Feb 10, 2026

Description

This pull request updates the PackageResourceCard.vue component to use the correct favicon for a package and to use the link provided by the resource (if supplied)

image

Related Issue(s)

closes #6669

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Copy Markdown
Contributor Author

E2E test fail on completely untouched/unrelated code:

  Running:  devices/settings/environment.spec.js                                          (45 of 49)


  FlowFuse - Device - Settings Environment
    1) can add, remove mark as hidden instance environment variables


  0 passing (4s)
  1 failing

  1) FlowFuse - Device - Settings Environment
       can add, remove mark as hidden instance environment variables:
     TypeError: The following error originated from your application code, not from Cypress.

  > Cannot read properties of null (reading 'classList')

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.66%. Comparing base (caa8232) to head (96bf6ef).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6678   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files         398      398           
  Lines       20103    20103           
  Branches     4841     4841           
=======================================
  Hits        15411    15411           
  Misses       4692     4692           
Flag Coverage Δ
backend 76.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Steve-Mcl Steve-Mcl merged commit ba2ffcc into main Feb 10, 2026
33 of 34 checks passed
@Steve-Mcl Steve-Mcl deleted the 6669-wrong-url-and-favicon branch February 10, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expert links to non existing source for some resources (404s)

2 participants