Skip to content

Safeguard dialog.close call with optional chaining to prevent potential runtime errors#6808

Merged
hardillb merged 1 commit intomainfrom
fix/device-tunnel-loader
Mar 5, 2026
Merged

Safeguard dialog.close call with optional chaining to prevent potential runtime errors#6808
hardillb merged 1 commit intomainfrom
fix/device-tunnel-loader

Conversation

@cstns
Copy link
Copy Markdown
Contributor

@cstns cstns commented Mar 5, 2026

Description

image

Was able to replicate the above on prod following the changes in the previous pr.

Safeguarding the catch route in order to pass the custom error through.

Related Issue(s)

follow up on #6798
part of #6797

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (5a6825f) to head (9d1c119).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6808   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files         398      398           
  Lines       20122    20122           
  Branches     4844     4844           
=======================================
  Hits        15414    15414           
  Misses       4708     4708           
Flag Coverage Δ
backend 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb hardillb merged commit 43dfb76 into main Mar 5, 2026
29 of 30 checks passed
@hardillb hardillb deleted the fix/device-tunnel-loader branch March 5, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants