Skip to content

[6820] Pinia Task 4 - ux-drawers #6856

Merged
cstns merged 10 commits intomainfrom
6820-pinia-task-4-ux-drawers
Mar 17, 2026
Merged

[6820] Pinia Task 4 - ux-drawers #6856
cstns merged 10 commits intomainfrom
6820-pinia-task-4-ux-drawers

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Mar 11, 2026

Description

⚠️ Heads up this is cut from 6806-pinia-task-3-ux-navigation. Need to close out #6838 prior to merging this in & swap the branch to main.

See details and test plan.

Related Issue(s)

Resolves #6820

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this Mar 11, 2026
@n-lark n-lark changed the base branch from main to 6806-pinia-task-3-ux-navigation March 11, 2026 20:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.64%. Comparing base (8ba182d) to head (7f1a60d).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6856   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files         399      399           
  Lines       20159    20159           
  Branches     4855     4855           
=======================================
  Hits        15451    15451           
  Misses       4708     4708           
Flag Coverage Δ
backend 76.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@n-lark n-lark requested a review from cstns March 12, 2026 19:17
@n-lark n-lark marked this pull request as ready for review March 12, 2026 19:17
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Switching to pinia also fixed a reactivity issue in which the right drawer remaining open even though no menu items were available.

You did miss a drawer usage withing the expert component @ frontend/src/components/expert/Expert.vue:189

@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 17, 2026

also, daisy chaining this PR will alleviate some of the merge conflicts which we'll fix on the ux nav PR

@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 17, 2026

Need to close out #6838 prior to merging this in & swap the branch to main.

This happens by default when the target branch gets merged

@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 17, 2026

re-running the ee e2e tests, feels like a fail due to flakiness

@n-lark n-lark requested a review from cstns March 17, 2026 14:46
Base automatically changed from 6806-pinia-task-3-ux-navigation to main March 17, 2026 14:59
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@cstns cstns merged commit 35df20a into main Mar 17, 2026
30 checks passed
@cstns cstns deleted the 6820-pinia-task-4-ux-drawers branch March 17, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinia Task 4 - ux-drawers

2 participants