Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6856 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 399 399
Lines 20159 20159
Branches 4855 4855
=======================================
Hits 15451 15451
Misses 4708 4708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into 6820-pinia-task-4-ux-drawers merged
frontend/src/pages/team/Tables/Table/TableExplorer/components/TablesList.vue
Outdated
Show resolved
Hide resolved
… into 6820-pinia-task-4-ux-drawers merged
…a imports for actions
cstns
left a comment
There was a problem hiding this comment.
Looking good! Switching to pinia also fixed a reactivity issue in which the right drawer remaining open even though no menu items were available.
You did miss a drawer usage withing the expert component @ frontend/src/components/expert/Expert.vue:189
|
also, daisy chaining this PR will alleviate some of the merge conflicts which we'll fix on the ux nav PR |
This happens by default when the target branch gets merged |
|
re-running the ee e2e tests, feels like a fail due to flakiness |
Description
6806-pinia-task-3-ux-navigation. Need to close out #6838 prior to merging this in & swap the branch tomain.See details and test plan.
Related Issue(s)
Resolves #6820
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel