Ensure getProjectsToUpgrade Matches all Project Settings#6870
Merged
Conversation
When looking at why only a few projects where updated, noticed that the query only matches settings that also include a restart flag. This now tests for just bare hour markers.
Contributor
Author
|
I have tested this locally. There is also a possible update to the task that checks for team type changes to add the |
knolleary
approved these changes
Mar 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6870 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 399 399
Lines 20155 20155
Branches 4851 4851
=======================================
Hits 15447 15447
Misses 4708 4708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When looking at why only a few projects where updated, noticed that the query only matches settings that also include a restart flag.
This now tests for just bare hour markers.