Skip to content

Ensure getProjectsToUpgrade Matches all Project Settings#6870

Merged
knolleary merged 1 commit intomainfrom
fix-auto-stack-upgrade
Mar 14, 2026
Merged

Ensure getProjectsToUpgrade Matches all Project Settings#6870
knolleary merged 1 commit intomainfrom
fix-auto-stack-upgrade

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

Description

When looking at why only a few projects where updated, noticed that the query only matches settings that also include a restart flag.

This now tests for just bare hour markers.

When looking at why only a few projects where updated, noticed
that the query only matches settings that also include a restart
flag.

This now tests for just bare hour markers.
@hardillb hardillb requested a review from knolleary March 14, 2026 18:20
@hardillb hardillb self-assigned this Mar 14, 2026
@hardillb
Copy link
Copy Markdown
Contributor Author

I have tested this locally.

There is also a possible update to the task that checks for team type changes to add the restart: false to the injected setting, but that can wait till Monday

@knolleary knolleary enabled auto-merge March 14, 2026 18:31
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.64%. Comparing base (f8a4655) to head (3799979).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6870   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files         399      399           
  Lines       20155    20155           
  Branches     4851     4851           
=======================================
  Hits        15447    15447           
  Misses       4708     4708           
Flag Coverage Δ
backend 76.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knolleary knolleary merged commit 263cbca into main Mar 14, 2026
30 checks passed
@knolleary knolleary deleted the fix-auto-stack-upgrade branch March 14, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants