Conversation
fixes #6872 This adds a 1 second delay between suspend and restart and another 1 second after each instance in the list. It also no longer tries to upgrade suspended instnaces
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6874 +/- ##
=======================================
Coverage 76.62% 76.62%
=======================================
Files 399 399
Lines 20160 20165 +5
Branches 4852 4856 +4
=======================================
+ Hits 15448 15452 +4
- Misses 4712 4713 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/FlowFuse/flowfuse into rate-limit-autostack-update-task
|
Do we have insight on what the api rate limits are? Adding these delays will slow down the calls we make, but not deal with the overall volume. Is the retry handling going into the driver separately? It feels like this code should leave a previously running instance in suspended state - but is it this code's responsibility or the drivers? |
hardillb
left a comment
hardillb
left a comment
There was a problem hiding this comment.
Doubling the pauses to just really be sure
Co-authored-by: Ben Hardill <b.hardill@gmail.com>
|
@knolleary doubles the waits |
2 participants
fixes #6872
Description
This adds a 1 second delay between suspend and restart and another 1 second after each instance in the list.
It also no longer tries to upgrade suspended instances.
Related Issue(s)
#6872
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel