Skip to content

[6826] Pinia Task 9 - product-expert-ff-agent#6882

Merged
n-lark merged 11 commits intomainfrom
6826-pinia-task-9-product-expert-ff-agent
Mar 25, 2026
Merged

[6826] Pinia Task 9 - product-expert-ff-agent#6882
n-lark merged 11 commits intomainfrom
6826-pinia-task-9-product-expert-ff-agent

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Mar 16, 2026

Description

See details here.

⚠️ This is cut from 6825-pinia-task-8-product-assistant to daisy chain.

No UI test plan required for this task.

The product-expert-ff-agent Pinia store has no direct component consumers, all access goes through the parent product/expert Vuex module, which remains unchanged. There is nothing new visible in the UI as a result of this PR.

The only user-facing behavior to verify is:

  • Login: no console errors on page load
  • Logout: useProductExpertFfAgentStore().$reset() fires cleanly; no console errors

All store logic (state initialization, reset(), setSessionCheckTimer()) is covered by the 18 unit tests in test/unit/frontend/stores/product-expert-ff-agent.spec.js.

Related Issue(s)

Resolves #6826

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns March 16, 2026 20:52
@n-lark n-lark self-assigned this Mar 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (d0e74f8) to head (bee19f4).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6882   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files         403      403           
  Lines       20293    20293           
  Branches     4880     4880           
=======================================
  Hits        15482    15482           
  Misses       4811     4811           
Flag Coverage Δ
backend 76.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@n-lark n-lark force-pushed the 6826-pinia-task-9-product-expert-ff-agent branch from 3101c53 to 1618597 Compare March 17, 2026 17:33
@n-lark n-lark changed the base branch from main to 6825-pinia-task-8-product-assistant March 17, 2026 17:35
…ant' into 6826-pinia-task-9-product-expert-ff-agent

merged
@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 22, 2026

This is not right, both the ff-agent and operator stores are used intensively within the expert store dynamically, wherever [state.agentMode] is used

Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 23, 2026

we should also rename the store and agent key while we're at it. We settled on insights with product after a couple of variations and we should also switch to it to avoid disconnects moving forward

@n-lark n-lark force-pushed the 6825-pinia-task-8-product-assistant branch from 5759fdb to e0ab437 Compare March 23, 2026 13:17
…ant' into 6826-pinia-task-9-product-expert-ff-agent
@n-lark
Copy link
Copy Markdown
Contributor Author

n-lark commented Mar 23, 2026

Hey @cstns

This is not right, both the ff-agent and operator stores are used intensively within the expert store dynamically, wherever [state.agentMode] is used

As discussed in slack, we are waiting to convert the vuex store to pinia so we don't do double the work here. This is just a file setup PR.

we should also rename the store and agent key while we're at it. We settled on insights with product after a couple of variations and we should also switch to it to avoid disconnects moving forward

Updated the name as below. For the agent key - I'll update that in the Task 11 PR.

const useProductExpertInsightsAgentStore = defineStore('product-expert-insights-agent', {

@n-lark n-lark requested a review from cstns March 23, 2026 15:53
@cstns
Copy link
Copy Markdown
Contributor

cstns commented Mar 23, 2026

yes, my bad, I was expecting everything to be done in one go

Base automatically changed from 6825-pinia-task-8-product-assistant to main March 25, 2026 16:40
@n-lark n-lark merged commit fd9cbff into main Mar 25, 2026
33 of 36 checks passed
@n-lark n-lark deleted the 6826-pinia-task-9-product-expert-ff-agent branch March 25, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinia Task 9 - product-expert-ff-agent

2 participants