Skip to content

Add FF_INSTANCE_URL to hosted instance env vars#7024

Merged
hardillb merged 7 commits intomainfrom
include-instance-url-env-var
Apr 7, 2026
Merged

Add FF_INSTANCE_URL to hosted instance env vars#7024
hardillb merged 7 commits intomainfrom
include-instance-url-env-var

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

@hardillb hardillb commented Apr 7, 2026

fixes #6984

Description

Adds the FF_INSTANCE_URL env var to the instance.

Will return the default hostname or if enabled the custom hostname

Related Issue(s)

#6984

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

hardillb added 2 commits April 7, 2026 10:19
fixes #6984

Adds the `FF_INSTANCE_URL` env var to the instance.

Will return the default hostname or if enabled the custom hostname
@hardillb hardillb requested a review from Steve-Mcl April 7, 2026 09:22
@hardillb hardillb self-assigned this Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.26%. Comparing base (2f4ad13) to head (1701dbb).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7024   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files         403      403           
  Lines       20312    20317    +5     
  Branches     4886     4890    +4     
=======================================
+ Hits        15490    15495    +5     
  Misses       4822     4822           
Flag Coverage Δ
backend 76.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb
Copy link
Copy Markdown
Contributor Author

hardillb commented Apr 7, 2026

There are lot of places in the tests that count the number of env vars

@cstns
Copy link
Copy Markdown
Contributor

cstns commented Apr 7, 2026

There are lot of places in the tests that count the number of env vars

yes, not the best approach

Comment thread test/unit/forge/routes/api/project_spec.js Outdated
Comment thread test/unit/forge/routes/api/project_spec.js Outdated
Comment thread forge/db/models/Project.js Outdated
Copy link
Copy Markdown
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, i have forgotton how to do reviews (added comments instead of "Start a review!") never mind.

1 change request + 2 suggestions added.

hardillb and others added 2 commits April 7, 2026 11:56
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go.

@hardillb hardillb merged commit 62c9cf5 into main Apr 7, 2026
33 checks passed
@hardillb hardillb deleted the include-instance-url-env-var branch April 7, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FF_INSTANCE_URL to instance settings

3 participants