[7065] Typescript: Phase 2 — Domain Types#7067
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7067 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 405 405
Lines 20348 20348
Branches 4895 4895
=======================================
Hits 15525 15525
Misses 4823 4823
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@n-lark, @ppawlowski was gracious to lend a hand and setup the ci step to check for TS spec drift we can work off that |
cstns
left a comment
There was a problem hiding this comment.
As an additional thing, the ci action is throwing an error due to diff's being detected in the /frontend/src/types/generated.ts file. For some reason this is not happening locally.
You can check the new ci action logs for more details
|
Hey @cstns @ppawlowski - First Piotr thank you for setting up the test 💪 Second, the test is failing and I think this is why, please advice on what you all think is best. CI Drift Failure — EE Schema ProblemWhat's happening
The committed Solution
|
Description
See #7065
See comment here around some issues with optional properties
Related Issue(s)
Resolves #7065
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel