Skip to content

Force Device Editor to reload if it fails first time#7129

Merged
hardillb merged 6 commits into
mainfrom
test-device-editor-refresh
Apr 24, 2026
Merged

Force Device Editor to reload if it fails first time#7129
hardillb merged 6 commits into
mainfrom
test-device-editor-refresh

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

@hardillb hardillb commented Apr 23, 2026

Description

Force refresh if editor load fails first time, rather than return a raw string with the 502 return a html file with hte meta tag to force a refresh after 3 seconds

Related Issue(s)

#6797

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (2b3a0ec) to head (c470cca).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7129   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files         405      405           
  Lines       20348    20348           
  Branches     4895     4895           
=======================================
  Hits        15525    15525           
  Misses       4823     4823           
Flag Coverage Δ
backend 76.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb hardillb changed the title Test device editor refresh Force Device Editor to reload if it fails first time Apr 23, 2026
@hardillb hardillb self-assigned this Apr 23, 2026
Comment thread forge/ee/routes/deviceEditor/index.js Outdated
Copy link
Copy Markdown
Contributor

@allthedoll allthedoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comma comment but otherwise i think this is fine

Co-authored-by: Jamie Strusz <5758031+allthedoll@users.noreply.github.com>
@hardillb hardillb merged commit 6961d4a into main Apr 24, 2026
31 checks passed
@hardillb hardillb deleted the test-device-editor-refresh branch April 24, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants