Skip to content

Prevent Google Social Login token reuse#7150

Merged
Steve-Mcl merged 5 commits into
mainfrom
prevent-google-sso-token-reuse
May 1, 2026
Merged

Prevent Google Social Login token reuse#7150
Steve-Mcl merged 5 commits into
mainfrom
prevent-google-sso-token-reuse

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

fixes FlowFuse/security#114

Description

Keeps a cache of used tokens until they expire

Related Issue(s)

FlowFuse/security#114

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

fixes FlowFuse/security#114

Keeps a cache of used tokens until they expire
@hardillb hardillb requested a review from knolleary April 28, 2026 15:41
@hardillb hardillb self-assigned this Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.58%. Comparing base (264fe16) to head (ba53952).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/sso/social/google.js 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7150      +/-   ##
==========================================
- Coverage   76.60%   76.58%   -0.02%     
==========================================
  Files         405      405              
  Lines       20573    20580       +7     
  Branches     4973     4974       +1     
==========================================
+ Hits        15759    15762       +3     
- Misses       4814     4818       +4     
Flag Coverage Δ
backend 76.58% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread forge/ee/routes/sso/social/google.js Outdated
Base automatically changed from 1178-app-cache-ttl to main April 29, 2026 10:14
@Steve-Mcl Steve-Mcl merged commit 462b88a into main May 1, 2026
30 of 31 checks passed
@Steve-Mcl Steve-Mcl deleted the prevent-google-sso-token-reuse branch May 1, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants