Skip to content

[7158 + 7152] Follow Ups: Remote Instance "Add to group" button breaks out of immersive mode + "Change instance type" breaks out of immersive mode#7171

Open
n-lark wants to merge 1 commit intomainfrom
7152-7158-route-name
Open

[7158 + 7152] Follow Ups: Remote Instance "Add to group" button breaks out of immersive mode + "Change instance type" breaks out of immersive mode#7171
n-lark wants to merge 1 commit intomainfrom
7152-7158-route-name

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Apr 29, 2026

Description

✅ All tests passed
  • 7152 immersive nav: hosted instance → immersive editor → Settings → Danger → click Change Instance Type. Stays in immersive (URL has /editor/settings/change-type, route instance-editor-settings-change-type).
  • 7152 immersive submit: on the change-type page, pick a new type and Confirm Changes. Lands on instance-editor-overview (immersive chrome stays), not /instance/:id/overview.
  • 7152 non-immersive (no-regression): non-immersive Settings → Danger → Change Instance Type → Confirm Changes. Goes to instance-settings-change-type, then Instance (→ instance-overview) as before.
  • 7158 immersive: remote instance assigned to an application → immersive editor → Overview → pencil next to Group. Lands on device-editor-settings?highlight=device-group-section; immersive chrome stays.
  • 7158 non-immersive (no-regression): non-immersive device Overview → pencil → device-settings with the same query.

Related Issue(s)

Resolves #7158
Resolves #7152

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns April 29, 2026 17:44
@n-lark n-lark self-assigned this Apr 29, 2026
@n-lark n-lark changed the title Ensure change type and group stay in immersive drawer [7158 + 7152] Follow Ups: Remote Instance "Add to group" button breaks out of immersive mode + "Change instance type" breaks out of immersive mode Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (424fbb5) to head (d26cbc3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7171   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         405      405           
  Lines       20427    20427           
  Branches     4925     4925           
=======================================
  Hits        15650    15650           
  Misses       4777     4777           
Flag Coverage Δ
backend 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow Up: Remote Instance "Add to group" button breaks out of immersive mode Follow Up: "Change instance type" breaks out of immersive mode

1 participant