Skip to content

[7165 + 7164 + 7163 + 7162] Wire device-updated / assign-device events into the immersive remote-instance editor#7172

Open
n-lark wants to merge 1 commit intomainfrom
7162-7163-7164-7165-event-wiring
Open

[7165 + 7164 + 7163 + 7162] Wire device-updated / assign-device events into the immersive remote-instance editor#7172
n-lark wants to merge 1 commit intomainfrom
7162-7163-7164-7165-event-wiring

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Apr 29, 2026

Description

This wraps the following changes into one PR:

  1. Follow Up: Remote Instance group assignment UI does not refresh in immersive mode #7163
  2. Follow Up: Remote Instance application assignment broken in immersive mode #7162
  3. Follow Up: Remote Instance save settings button stays enabled after saving environment variable in immersive mode #7164
  4. Follow Up: Remote Instances Save Settings button stays enabled after saving max HTTP payload size in immersive mode #7165
✅ All tests passed!
  • 7162 immersive Assign (unassigned device): unassigned remote instance → immersive editor → Settings → click Assign. Dialog opens; pick Instance or Application and confirm. Device updates without manual reload; Assign UI flips to assigned state.
  • 7162 Unassign → Assign cycle: assigned remote instance → immersive Settings → Unassign. Assign button re-enables and is responsive immediately (no stale state, no manual reload).
  • 7163 group Remove + Reassign: application-owned remote instance currently in a device group → immersive Settings → General → in the Group section, click Remove from the group. Section flips to "no group" state immediately. Then click Reassign (or Assign to a group) and pick a group — section updates without manual reload.
    • Known limitation: group removal clears the active snapshot → editor.connected briefly false → pre-existing watcher in Editor/index.vue:213-227 bounces to device-overview. Out of scope for this bug fix.
  • 7164 env-var save: immersive Settings → Environment → add or modify a var → Save Settings. Button disables after success (no longer stays "dirty").
  • 7165 max-payload save: immersive Settings → Editor → change max HTTP payload size → Save Settings. Button disables after success.
  • Non-immersive (no-regression): repeat Follow Up: Remote Instance application assignment broken in immersive mode #7162-Follow Up: Remote Instances Save Settings button stays enabled after saving max HTTP payload size in immersive mode #7165 flows from non-immersive Settings — behavior unchanged from main.

Related Issue(s)

Resolves #7163
Resolves #7162
Resolves #7164
Resolves #7165

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns April 29, 2026 18:52
@n-lark n-lark self-assigned this Apr 29, 2026
@n-lark n-lark changed the title [7165 + 7164 + 7153 + 7162] Wire device-updated / assign-device events into the immersive remote-instance editor [7165 + 7164 + 7163 + 7162] Wire device-updated / assign-device events into the immersive remote-instance editor Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (424fbb5) to head (418ee32).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7172   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         405      405           
  Lines       20427    20427           
  Branches     4925     4925           
=======================================
  Hits        15650    15650           
  Misses       4777     4777           
Flag Coverage Δ
backend 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant