Skip to content

Ensure only Device Palette settings sent when changed#7175

Merged
hardillb merged 1 commit into
mainfrom
fix-device-palette-settings
Apr 30, 2026
Merged

Ensure only Device Palette settings sent when changed#7175
hardillb merged 1 commit into
mainfrom
fix-device-palette-settings

Conversation

@hardillb
Copy link
Copy Markdown
Contributor

@hardillb hardillb commented Apr 30, 2026

fixes #7166

Description

When saving the palette changes the component was requesting the whole settings object and only updating the npmrc file and the catalogues, but this also included the sanitised security settings which includes pass: true to show if a password is set, but not it's value (or hashed value). This needed to be removed before it is returned.

Related Issue(s)

#7166

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from cstns April 30, 2026 08:50
@hardillb hardillb self-assigned this Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.59%. Comparing base (424fbb5) to head (5d1a7f8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7175      +/-   ##
==========================================
- Coverage   76.61%   76.59%   -0.02%     
==========================================
  Files         405      405              
  Lines       20427    20427              
  Branches     4925     4925              
==========================================
- Hits        15650    15646       -4     
- Misses       4777     4781       +4     
Flag Coverage Δ
backend 76.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow Up: 500 error when setting npm configuration file or Node Catalogues entry on remote instance

2 participants