Refactor/account settings feature checks#7176
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7176 +/- ##
=======================================
Coverage 76.61% 76.61%
=======================================
Files 405 405
Lines 20427 20427
Branches 4925 4925
=======================================
Hits 15650 15650
Misses 4777 4777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
n-lark
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The featuresCheck getter in account-settings.js has ~130 lines of repetitive boilerplate. Nearly every feature follows the same 3-property pattern and there are several naming inconsistencies that have drifted in over time. The goal is to replace the boilerplate with a data-driven config table + builder function, and fix all naming inconsistencies across the app since we're building on top of it.
Something the we should be considering is removing the built in functionality that surrounded the now defunct free team tier. For now i just hardcoded the complex eligibility check and disabled e2e tests that were covering it.
Related Issue(s)
part of #7168
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel