Improve snapshot comparison viewer UX#7202
Merged
Merged
Conversation
- Replace "Simple view" button with a "…" options menu containing "Simple view" (hides position changes) and "Expand all" (expands all property panels by default); both settings persist via localStorage - Panels now default to expanded; toggling "Expand all" collapses/expands live panels immediately - Wire changes now render one badge per node instead of comma-joined text, making individual wire targets visually distinct - Fix diff viewer background colours not extending to the full scroll width on shorter lines when a longer line is present - Fix "N unchanged lines" button not spanning the full horizontal width
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7202 +/- ##
=======================================
Coverage 76.60% 76.60%
=======================================
Files 405 405
Lines 20577 20577
Branches 4973 4973
=======================================
Hits 15762 15762
Misses 4815 4815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
n-lark
requested changes
May 5, 2026
added 2 commits
May 5, 2026 22:47
- Replace custom … button + backdrop with ff-kebab-menu / ff-kebab-item, getting DotsVerticalIcon, click-outside and teleport for free - Move hidePositionChanges / expandedByDefault into a new ux-snapshot-diff Pinia store with pinia-plugin-persistedstate; prefs now reset on logout so they cannot leak across users on a shared browser - Add useUxSnapshotDiffStore to the account-auth logout $reset() chain - Remove the now-unused formatWirePort method from SnapshotDiffChangePanel
Remove the hard-coded data-click-exclude="right-drawer" from KebabMenu.vue and instead expose a menuItemsAttrs prop so callers can pass any extra attributes to the teleported MenuItems element. Only AssetCompareDialog sets this — which needs it because the comparison dialog is mounted inside SnapshotDetailsDrawer (in the right drawer) and the teleported kebab options were triggering the drawer's v-click-outside handler.
cstns
requested changes
May 6, 2026
| :data-el="'kebab-item-' + slugify(label)" | ||
| > | ||
| <component :is="icon" /> | ||
| <component :is="icon" class="ff-icon" /> |
Contributor
There was a problem hiding this comment.
we should also gate it based on a v-if="icon"
|
|
||
| export const useUxSnapshotDiffStore = defineStore('ux-snapshot-diff', { | ||
| state: () => ({ | ||
| hidePositionChanges: false, |
Contributor
There was a problem hiding this comment.
A dedicated store isn't warranted for this feature, as its sole purpose would be managing snapshot diff state. Instead, these props can be kept as ephemeral state within the AssetCompareDialog component, using predefined defaults.
A store would be warranted if centralized state management was needed across multiple components
- Move hidePositionChanges/expandedByDefault from ux-snapshot-diff Pinia store to ephemeral data() in AssetCompareDialog - Delete ux-snapshot-diff.js store and remove it from account-auth logout chain - Add v-if="icon" guard to KebabItem to avoid rendering null component
cstns
approved these changes
May 6, 2026
This was referenced May 6, 2026
n-lark
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7201
Summary
…options menu with two persistent settings:localStorageTest plan
…— verify dropdown shows "Simple view" and "Expand all" with correct checkmarksHow it looked before
How it looks after