Skip to content

fix: convert expert packages from grid to list layout#7209

Merged
cstns merged 2 commits into
mainfrom
fix/expert-packages-grid-to-list
May 6, 2026
Merged

fix: convert expert packages from grid to list layout#7209
cstns merged 2 commits into
mainfrom
fix/expert-packages-grid-to-list

Conversation

@andypalmi
Copy link
Copy Markdown
Contributor

@andypalmi andypalmi commented May 6, 2026

Summary

  • Replaces the 2-column CSS grid in PackagesList.vue with a single-column flex list so packages stack vertically
  • Removes the absolutely positioned Install/Manage button in PackageResourceCard.vue that was overlaying package names and URLs, making text unreadable
  • Wraps package name + URL in a new .package-text flex column that grows to fill available space, with the button placed inline at the row's right edge

Closes #7195

Before

image

After

Screenshot 2026-05-06 at 16 18 08

Test plan

  • Open FF Expert and trigger a response with suggested Node packages
  • Verify package names and URLs are fully readable
  • Verify Install/Manage button appears on the right side of each row without overlapping text
  • Verify clicking Install/Manage still works correctly

Closes #7195

Fixes a readability issue where the Install/Manage button was absolutely
positioned over the package name, making text unreadable in the 2-column grid.

Changes:
- PackagesList.vue: replaced CSS grid (repeat auto-fill minmax 200px) with a
  single-column flex list so packages stack vertically
- PackageResourceCard.vue: removed absolute positioning from .package-actions;
  wrapped package name + URL in a new .package-text flex column that grows to
  fill available space; placed the Install/Manage button inline at the row's
  right edge using flex-shrink: 0; removed position: relative from .package-card
  and the padding-right that compensated for the overlay

Closes #7195
@cstns cstns enabled auto-merge May 6, 2026 14:31
@cstns cstns merged commit a962b58 into main May 6, 2026
27 of 28 checks passed
@cstns cstns deleted the fix/expert-packages-grid-to-list branch May 6, 2026 14:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.59%. Comparing base (f2665ec) to head (7987073).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7209   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files         405      405           
  Lines       20580    20580           
  Branches     4975     4975           
=======================================
  Hits        15763    15763           
  Misses       4817     4817           
Flag Coverage Δ
backend 76.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change grid to table for suggested packages in FF Expert

2 participants