[7550] Fix rbac specs failing in CI #7555
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7555 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 410 410
Lines 21002 21002
Branches 5117 5117
=======================================
Hits 16162 16162
Misses 4840 4840
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Should we maybe dig into the root cause of why there are two concurrent |
|
Hey @cstns so the two calls are:
If we wanted to split the statuses into their own endpoint we could but I think that is a larger refactor than we should handle for this ticket. When I pick back up Replace HTTP polling of instance / device status with MQTT-over-WS |
needs a look at for sure but well see if we actually need to do something about it |
Description
These specs flaked because the Remote Instances page fires two concurrent
/teams/{id}/devicesrequests on load, the full list and a nameless statusOnly poll, and thebefore()hook's intercept matched both.It intermittently captured the response without device names and every
devices.find(i => i.name === …)returnedundefined. The fix narrows the intercept to the full request (which always carriespage=1, unlike the statusOnly poll), making the captured data match up.Related Issue(s)
Resolves #7550
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel