Skip to content

[7578] Hosted Instances search field auto-submits and clears input when no matching results are found#7597

Merged
cstns merged 1 commit into
mainfrom
7578-hosted-instances-search
Jun 23, 2026
Merged

[7578] Hosted Instances search field auto-submits and clears input when no matching results are found#7597
cstns merged 1 commit into
mainfrom
7578-hosted-instances-search

Conversation

@n-lark

@n-lark n-lark commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Problem was search box lives inside ff-data-table so empty results swapped the table for the loading spinner, unmounting it and wiping the input.

The fix: searchTerm starts null, becomes a string once touched ('' when cleared). Spinner only when searchTerm === null; table stays mounted while searchTerm !== null. So it never unmounts mid-search. No new flags.

Related Issue(s)

Resolves #7578

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns June 22, 2026 17:42
@n-lark n-lark self-assigned this Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.95%. Comparing base (1dc01e3) to head (553da0d).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7597      +/-   ##
==========================================
+ Coverage   76.93%   76.95%   +0.01%     
==========================================
  Files         410      410              
  Lines       21084    21084              
  Branches     5138     5138              
==========================================
+ Hits        16221    16225       +4     
+ Misses       4863     4859       -4     
Flag Coverage Δ
backend 76.95% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns cstns merged commit fca6d31 into main Jun 23, 2026
29 checks passed
@cstns cstns deleted the 7578-hosted-instances-search branch June 23, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hosted Instances search field auto-submits and clears input when no matching results are found

2 participants