Conversation
11 tasks
Contributor
Author
|
With these 2 PRs, we remove a lots of deps - most importantly, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7768 +/- ##
==========================================
- Coverage 75.39% 75.06% -0.34%
==========================================
Files 428 429 +1
Lines 22540 22715 +175
Branches 5945 6013 +68
==========================================
+ Hits 16994 17050 +56
- Misses 5546 5665 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
odd seemingly unrelated test fail: updating branch to main so tests re-run |
hardillb
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the dependency on the external
@node-red/utilpackage by introducing a local utility module and updating references to use it.This reduces transient dependencies (and make the codebase more self-contained).
NOTE:
there are minimal existing "happy path" tests in
test/unit/forge/ee/routes/staticAssets/index_spec.jsthat touchred_utilgetObjectProperty&setObjectProperty- let me know if you want more extensive tests.NOTE 2:
There is an additional fix for
path..normalizeadded to the stub driver atforge/containers/stub/index.js:12It was changed to use
path.posix.normalizeso that.split('/')works consistently on Windows and Linux.This was a pre-existing bug, not something you introduced here - it was latent because CI is Linux-only. My env is Windows.
Since it's the stub driver only (used for local dev/tests, not production containers), the impact was limited to running these tests on Windows - but the posix fix should make this portable.
Dependency removal and refactoring:
@node-red/utilfrom thepackage.jsondependencies.New utility module:
forge/containers/stub/red_util.js, which provides the implementation required to pass tests. NOTE: the code was linted to permit clean lint check. See original code in NR repoutil/lib/util.jsfor reference.Related Issue(s)
closes #7765
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel