All links to Privacy Policy look to be broken

[hardillb]

Current Behavior

See failed action on FlowFuse/flowfuse#7328

It looks like part of the Nuxt migration merged last week removed the link validor https://github.com/FlowFuse/website/pull/4984/changes#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88L54

Expected Behavior

Links to work

Steps To Reproduce

No response

Environment

• Date:
• Platform/OS:
• Browser:

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

[Yndira-E]

Hey @hardillb untitaker/hyperlink was replaced by nuxt-link-checker in that PR you mentioned. Since /privacy-policy was migrated to Nuxt, it no longer exists in the 11ty output, causing this false positive.

[hardillb]

Ok so we need to all the docs tests in the flowfuse repo // @ppawlowski

[ppawlowski]

@Yndira-E Clould you expand on how links validation is currently working? Is it executed as a part of build:nuxt:skip-images npm script?

[Yndira-E]

After investigating further, nuxt-link-checker only checks the 2 explicitly prerendered Nuxt pages (/terms and /privacy-policy) and skips all links to 11ty pages, so it wasn't providing real coverage.

I've opened PR #5057 which brings back untitaker/hyperlink pointing to nuxt/.output/public/, the directory that contains the full combined 11ty + Nuxt output, and also what Netlify deploys.

The flowfuse docs.yml will need two changes:

npm run build:skip-images → npm run build:nuxt:skip-images
Hyperlink args: website/_site/ → website/nuxt/.output/public/