V2s - update ais balance fields#43
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e1ab499f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "required": [ | ||
| "accountId", | ||
| "currency" | ||
| ] |
There was a problem hiding this comment.
The updated AisAccount schema now requires only currency, while iban remains explicitly optional ("IBAN when available."). This allows account records with no stable identifier at all, which makes downstream account selection and correlation impossible whenever a provider does not return IBANs. Please require at least one identifier (iban or a fallback such as the previous accountId) so clients can always reference a specific account.
Useful? React with 👍 / 👎.
| "required": [ | ||
| "accountId", | ||
| "asOf", | ||
| "date", | ||
| "currency" | ||
| ] |
There was a problem hiding this comment.
AisBalance.required now includes only date and currency, and iban is optional, so balance entries can be emitted without any account key. In multi-account consents (or providers that omit IBAN), consumers cannot map a returned balance to an account, which breaks per-account balance views and reconciliation. Keep an always-present identifier (iban or legacy accountId) in the required set.
Useful? React with 👍 / 👎.
| "required": [ | ||
| "transactionId", | ||
| "accountId", | ||
| "bookingDate", | ||
| "amount", | ||
| "currency" |
There was a problem hiding this comment.
After replacing accountId with optional iban, the AisTransaction required list no longer guarantees any account identifier. For transaction listings that include multiple consented accounts, entries without IBAN become unattributable, so clients cannot reliably group or filter transactions per account. Require iban or retain a mandatory fallback identifier.
Useful? React with 👍 / 👎.
2 participants
No description provided.