Skip to content

Fix javadoc #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix javadoc #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd7857
ci: configure Javadoc failOnWarnings
javier-godoy Apr 7, 2025
cfe3cc8
docs: fix javadoc warnings
javier-godoy Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@
<configuration>
<quiet>true</quiet>
<doclint>none</doclint>
<failOnWarnings>false</failOnWarnings>
<failOnWarnings>true</failOnWarnings>
<links>
<link>https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}</link>
</links>
Expand Down
7 changes: 3 additions & 4 deletions src/main/java/com/flowingcode/addons/applayout/AppLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,9 @@ public void setDrawerBelowHeader(boolean drawerBelowHeader) {
getElement().setAttribute("drawerBelowHeader", drawerBelowHeader);
}

/**
* Sets the drawerBelowHeader attribute so the drawer will be show below
* the header of the applayout
* @param drawerBelowHeader
/**
* Sets the alignment of the drawer to the right side.
* @param drawerRightAlignment
*/
public void setDrawerRightAlignment(boolean drawerRightAlignment) {
getElement().setAttribute("drawerAlign", drawerRightAlignment?"right":"left");
Expand Down