Skip to content

ci: add jakarta.servlet-api to v25 profile#61

Open
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Open

ci: add jakarta.servlet-api to v25 profile#61
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #60

Summary by CodeRabbit

  • Chores
    • Updated build dependencies to support testing infrastructure enhancements for the v25 profile.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a1106a1-5760-4645-a73d-19218550a46d

📥 Commits

Reviewing files that changed from the base of the PR and between 3d20981 and 4bb4d2a.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

Adds a test-scoped Maven dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 profile in pom.xml. This restores a missing transitive dependency previously provided by vaadin-testbench-unit, which was dropped in Vaadin 25.1.x versions.

Changes

Cohort / File(s) Summary
Maven Configuration
pom.xml
Added test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 dependency to v25 profile to resolve missing servlet API classes at test runtime.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding the jakarta.servlet-api dependency to the v25 Maven profile, which is the primary objective of this pull request.
Linked Issues check ✅ Passed The pull request adds the jakarta.servlet-api:6.1.0 test-scoped dependency to the v25 profile as required by issue #60 to fix the SerializationTest failure.
Out of Scope Changes check ✅ Passed The pull request contains only the required dependency addition to pom.xml with no out-of-scope changes outside the stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 22, 2026 15:42
@sonarqubecloud
Copy link

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy javier-godoy marked this pull request as ready for review March 23, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

1 participant