fix: update color-scheme when switching themes

[javier-godoy]

See https://github.com/vaadin/flow/blob/eb7860193f87a55328c08110d5ff0f453c6158a1/flow-server/src/main/java/com/vaadin/flow/component/page/Page.java#L88-L94

Summary by CodeRabbit

• Refactor
  • Streamlined theme management by consolidating attribute initialization logic into a unified processing block. Previously duplicate code branches for different rendering contexts are now consolidated into a single mechanism. Theme and color scheme settings are applied consistently across all contexts, improving code quality, maintainability, and consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The applyThemeAttribute method in TabbedDemo is refactored to consolidate iframe and non-iframe branches. Instead of setting theme attributes inline in each branch, both now initialize a documentElement variable and execute a unified script block to apply theme and colorScheme attributes, reducing code duplication.

Changes

Cohort / File(s)	Summary
TabbedDemo theme attribute refactoring src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java	Refactored applyThemeAttribute method to consolidate iframe and non-iframe logic paths. Both branches now initialize a local documentElement variable and append a common script block for setting theme and colorScheme attributes, replacing previous inline attribute setting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat: add getThemeAttribute and applyThemeAttribute methods AND remove!: remove deprecated methods and classes #127: Modifies the same applyThemeAttribute method in TabbedDemo, introducing or refining theme attribute handling logic.

Suggested reviewers

• mlopezFC
• paodb

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'fix: update color-scheme when switching themes' directly matches the main objective and primary change in the changeset, which consolidates theme-setting logic and ensures color-scheme is updated when themes are switched.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud