Skip to content

Initial implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2025
Merged

Initial implementation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d929d5
feat: first implementation
sofia-nunez May 15, 2025
5a01ffd
docs: fix javadoc comments
sofia-nunez May 28, 2025
648d2e7
feat: add translation provider to demo
sofia-nunez May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Bug Report
description: Please report issues related to TEMPLATE_ADDON here.
description: Please report issues related to Cron Expression Editor Add-on here.
body:
- type: textarea
id: problem-description
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Feature Request
description: Please add feature suggestions related to TEMPLATE_ADDON here.
description: Please add feature suggestions related to Cron Expression Editor Add-on here.
body:
- type: textarea
id: feature-proposal
Expand Down
46 changes: 32 additions & 14 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/template-add-on)
[![Stars on vaadin.com/directory](https://img.shields.io/vaadin-directory/star/template-add-on.svg)](https://vaadin.com/directory/component/template-add-on)
[![Build Status](https://jenkins.flowingcode.com/job/template-addon/badge/icon)](https://jenkins.flowingcode.com/job/template-addon)
[![Maven Central](https://img.shields.io/maven-central/v/com.flowingcode.vaadin.addons/template-addon)](https://mvnrepository.com/artifact/com.flowingcode.vaadin.addons/template-addon)
[![Javadoc](https://img.shields.io/badge/javadoc-00b4f0)](https://javadoc.flowingcode.com/artifact/com.flowingcode.vaadin.addons/template-addon)
[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/cron-expression-editor-add-on)
[![Stars on vaadin.com/directory](https://img.shields.io/vaadin-directory/star/cron-expression-editor-add-on.svg)](https://vaadin.com/directory/component/cron-expression-editor-add-on)
[![Build Status](https://jenkins.flowingcode.com/job/CronExpressionEditor-addon/badge/icon)](https://jenkins.flowingcode.com/job/CronExpressionEditor-addon)
[![Maven Central](https://img.shields.io/maven-central/v/com.flowingcode.vaadin.addons/cron-expression-editor-addon)](https://mvnrepository.com/artifact/com.flowingcode.vaadin.addons/cron-expression-editor-addon)
[![Javadoc](https://img.shields.io/badge/javadoc-00b4f0)](https://javadoc.flowingcode.com/artifact/com.flowingcode.vaadin.addons/cron-expression-editor-addon)

# Template Add-on
# Cron Expression Editor Add-on

This is a template project for building new Vaadin 24 add-ons
A component for Vaadin 24 that assists in the generation of cron expressions

## Features

* List the features of your add-on in here
* A mode to input daily, weekly and monthly expressions with the assistance of UI components
* An advanced mode to input cron expressions directly
* Calculation of the next dates scheduled by the generated cron expression
* Allows the configuration of a list of frequently used cron expressions

## Online demo

[Online demo here](http://addonsv24.flowingcode.com/template)
[Online demo here](http://addonsv24.flowingcode.com/cron-expression-editor)

## Download release

[Available in Vaadin Directory](https://vaadin.com/directory/component/template-add-on)
[Available in Vaadin Directory](https://vaadin.com/directory/component/cron-expression-editor-add-on)

### Maven install

Expand All @@ -27,7 +30,7 @@ Add the following dependencies in your pom.xml file:
```xml
<dependency>
<groupId>com.flowingcode.vaadin.addons</groupId>
<artifactId>template-addon</artifactId>
<artifactId>cron-expression-editor-addon</artifactId>
<version>X.Y.Z</version>
</dependency>
```
Expand All @@ -44,7 +47,7 @@ To see the demo, navigate to http://localhost:8080/

## Release notes

See [here](https://github.com/FlowingCode/TemplateAddon/releases)
See [here](https://github.com/FlowingCode/CronExpressionEditor/releases)

## Issue tracking

Expand All @@ -69,13 +72,28 @@ Then, follow these steps for creating a contribution:

This add-on is distributed under Apache License 2.0. For license terms, see LICENSE.txt.

TEMPLATE_ADDON is written by Flowing Code S.A.
CronExpressionEditor Add-on is written by Flowing Code S.A.

## Third-Party Dependencies

This project includes the following third-party dependency:

- **cron-expression-descriptor** – Licensed under the [MIT License](https://opensource.org/licenses/MIT).

# Developer Guide

## Getting started

Add your code samples in this section
```java
// Create a new instance
CronExpressionEditor editor = new CronExpressionEditor();

// Set default expression (optional)
editor.setDefaultExpression("0 0 12 * * ?");

// Add to your layout
add(editor);
```

## Special configuration when using Spring

Expand Down
38 changes: 28 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
<modelVersion>4.0.0</modelVersion>

<groupId>com.flowingcode.vaadin.addons</groupId>
<artifactId>template-addon</artifactId>
<artifactId>cron-expression-editor-addon</artifactId>
<version>1.0.0-SNAPSHOT</version>
<name>Template Add-on</name>
<description>Template Add-on for Vaadin Flow</description>
<name>Cron Expression Editor Add-on</name>
<description>Component that assists in the generation of cron expressions</description>
<url>https://www.flowingcode.com/en/open-source/</url>

<properties>
Expand All @@ -20,8 +20,10 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<drivers.dir>${project.basedir}/drivers</drivers.dir>
<jetty.version>11.0.20</jetty.version>
<cron.expression.descriptor.version>1.2.10</cron.expression.descriptor.version>
<day.of.week.selector.version>1.0.0</day.of.week.selector.version>
<spring.context.version>6.2.5</spring.context.version>
Comment on lines +23 to +25
Copy link

@coderabbitai coderabbitai bot May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify dependency versions for security and compatibility.

Ensure the specified versions are current and secure.

🏁 Script executed:

#!/bin/bash
# Check Maven Central for latest versions of the new dependencies

echo "Checking cron-expression-descriptor latest version:"
curl -s "https://search.maven.org/solrsearch/select?q=g:it.burning+AND+a:cron-expression-descriptor&rows=1&wt=json" | jq -r '.response.docs[0].latestVersion // "Not found"'

echo "Checking day-of-week-selector-addon latest version:"
curl -s "https://search.maven.org/solrsearch/select?q=g:com.flowingcode.vaadin.addons+AND+a:day-of-week-selector-addon&rows=1&wt=json" | jq -r '.response.docs[0].latestVersion // "Not found"'

echo "Checking spring-context latest version:"
curl -s "https://search.maven.org/solrsearch/select?q=g:org.springframework+AND+a:spring-context&rows=1&wt=json" | jq -r '.response.docs[0].latestVersion // "Not found"'

Length of output: 877

Dependency Version Verification Results

  • cron-expression-descriptor (it.burning:cron-expression-descriptor) is already at the latest stable release (1.2.10).
  • day-of-week-selector-addon (com.flowingcode.vaadin.addons:day-of-week-selector-addon) has a patch update available: current 1.0.0 → latest 1.0.1.
  • spring-context (org.springframework:spring-context) shows 7.0.0-M5 on Maven Central, but that’s a milestone build. Unless you intend to adopt Spring Framework 7 milestones, it’s advisable to remain on the stable 6.2.x line or wait for a GA release.

Please update the day-of-week-selector version and confirm your intended strategy for Spring Context:

Suggested diff:

--- pom.xml
+++ pom.xml
@@ lines 23-25
-        <day.of.week.selector.version>1.0.0</day.of.week.selector.version>
+        <day.of.week.selector.version>1.0.1</day.of.week.selector.version>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<cron.expression.descriptor.version>1.2.10</cron.expression.descriptor.version>
<day.of.week.selector.version>1.0.0</day.of.week.selector.version>
<spring.context.version>6.2.5</spring.context.version>
<cron.expression.descriptor.version>1.2.10</cron.expression.descriptor.version>
<day.of.week.selector.version>1.0.1</day.of.week.selector.version>
<spring.context.version>6.2.5</spring.context.version>
🤖 Prompt for AI Agents 
In pom.xml lines 23 to 25, update the day.of.week.selector.version from 1.0.0 to
1.0.1 to use the latest patch release. For spring.context.version, confirm
whether to stay on the stable 6.2.5 line or plan for Spring Framework 7 GA; do
not switch to milestone versions unless intended. Adjust the version accordingly
based on this decision.

Copy link
Member

@javier-godoy javier-godoy Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai please create issue

Copy link

@coderabbitai coderabbitai bot Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@javier-godoy I've created a GitHub issue to track the dependency version updates identified in the code review. The issue includes details about updating the day-of-week-selector-addon to version 1.0.1 and considerations for the spring-context version strategy.

🏁 Script executed:

#!/bin/bash
# Create GitHub issue for dependency version updates
gh issue create \
  --title "Update dependency versions in pom.xml" \
  --body "## Issue Description

Following the code review in PR #1, the following dependency versions should be updated:

### Updates Required
- **day-of-week-selector-addon**: Update from 1.0.0 to 1.0.1 (patch release available)
- **spring-context**: Confirm strategy - stay on stable 6.2.5 or plan for Spring Framework 7 GA (avoid milestone versions)

### Details
The cron-expression-descriptor version 1.2.10 is already at the latest stable release and does not require updates.

### References
- PR: https://github.com/FlowingCode/CronExpressionField/pull/1
- Review comment: https://github.com/FlowingCode/CronExpressionField/pull/1#discussion_r2112211398
- Requested by: @javier-godoy" \
  --assignee javier-godoy

Length of output: 59

@javier-godoy Perfect! I've successfully created issue #4 to track the dependency version updates: #4

The issue includes:

  • Details about updating day-of-week-selector-addon from 1.0.0 to 1.0.1
  • Considerations for the spring-context version strategy
  • References to this PR and the specific review comment
  • Assignment to you as requested

The issue is now ready for tracking and can be addressed in a future PR.

🐰✨ Happy to help organize the follow-up work!

<flowingcode.commons.demo.version>4.2.0</flowingcode.commons.demo.version>
<frontend.hotdeploy>true</frontend.hotdeploy>
</properties>

<organization>
Expand Down Expand Up @@ -117,6 +119,21 @@
</pluginRepositories>

<dependencies>
<dependency>
<groupId>com.flowingcode.vaadin.addons</groupId>
<artifactId>day-of-week-selector-addon</artifactId>
<version>${day.of.week.selector.version}</version>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
<version>${spring.context.version}</version>
</dependency>
<dependency>
<groupId>it.burning</groupId>
<artifactId>cron-expression-descriptor</artifactId>
<version>${cron.expression.descriptor.version}</version>
</dependency>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-core</artifactId>
Expand Down Expand Up @@ -264,15 +281,16 @@
<scan>3</scan>
<!-- Use test scope because the UI/demo classes are in the test package. -->
<useTestScope>true</useTestScope>
<webApp>
<resourceBases>
<resourceBase>src/test/resources/META-INF/resources</resourceBase>
<resourceBase>src/main/resources/META-INF/resources</resourceBase>
</resourceBases>
</webApp>
<supportedPackagings>
<supportedPackaging>jar</supportedPackaging>
</supportedPackagings>
<systemProperties>
<vaadin.frontend.hotdeploy>true</vaadin.frontend.hotdeploy>
<systemProperty>
<key>vaadin.i18n.provider</key>
<value>com.flowingcode.vaadin.addons.cronexpressioneditor.TranslationProvider</value>
</systemProperty>
</systemProperties>
</configuration>
</plugin>
</plugins>
Expand Down
Loading