Skip to content

Check-commits with local network repositories takes too long #1

@javier-godoy

Description

@javier-godoy

check-commits take a long time to timeout if it cannot connect to the repository (in this case, we had a repository in 10.0.0.0/8):

image

The current implementation uses help:evaluate and requires resolution of dependencies against the repositories configured in the POM. With some caveats (see https://stackoverflow.com/a/56007185/1297272), we can just use grep, which is faster and doesn't require resolving dependencies.

- run: echo "VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_ENV
+ run: echo "VERSION=$(grep -oPm1 "(?<=<version>)[^<]+" "pom.xml")" >> $GITHUB_ENV && cat $GITHUB_ENV

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions