Skip to content

fix(demo): fix spacing in flex layout for aura/base themes#179

Merged
javier-godoy merged 1 commit intomasterfrom
issue-177
Apr 21, 2026
Merged

fix(demo): fix spacing in flex layout for aura/base themes#179
javier-godoy merged 1 commit intomasterfrom
issue-177

Conversation

@paodb
Copy link
Copy Markdown
Member

@paodb paodb commented Apr 21, 2026

Close #177

Summary by CodeRabbit

  • Refactor
    • Updated demo component layout spacing to use CSS gap styling instead of individual component margins for improved layout consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c11fbf0d-1bf8-4e7a-9e28-868911cede94

📥 Commits

Reviewing files that changed from the base of the PR and between 2f2e533 and 6c1b045.

📒 Files selected for processing (2)
  • src/test/java/com/flowingcode/vaadin/addons/googlemaps/AddMarkersDemo.java
  • src/test/java/com/flowingcode/vaadin/addons/googlemaps/DisableUIControlsDemo.java

Walkthrough

Two demo files were updated to resolve checkbox spacing issues in Aura and Base themes by replacing per-component margin classes with a container-level gap style on FlexLayout, affecting the Add Markers and Disable UI Controls demos.

Changes

Cohort / File(s) Summary
Demo Layout Spacing Updates
src/test/java/com/flowingcode/vaadin/addons/googlemaps/AddMarkersDemo.java, src/test/java/com/flowingcode/vaadin/addons/googlemaps/DisableUIControlsDemo.java
Replaced margin-based component spacing with gap CSS variable on FlexLayout containers. Changes govern spacing between form controls using Lumo/Vaadin CSS variables (--lumo-space-s, --vaadin-gap-m).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • javier-godoy
  • scardanzan
  • mlopezFC
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing spacing in flex layouts for Aura/Base themes in the demo files.
Linked Issues check ✅ Passed The PR addresses issue #177 by fixing checkbox spacing in the 'Add Markers' and 'Disable UI Controls' demos through CSS gap styling.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the spacing issue in the two affected demos; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-177

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@paodb paodb marked this pull request as ready for review April 21, 2026 20:03
@javier-godoy javier-godoy merged commit 1514273 into master Apr 21, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Apr 21, 2026
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Demo: checkbox spacing issue with Aura & Base themes

2 participants