Skip to content

Conversation

@javier-godoy
Copy link
Member

I've made some refactors in HasRpcSupport that aim to pave the way for an upcoming feature. Here's a summary of the changes:

  • Moved the InvocationHandler implementation to a standalone class, separating it from its previous location.
  • Transferred the HasRpcSupport.call method to the InvocationHandler, providing a more cohesive structure (there is no need to have call as a public method in HasRpcSupport because RPC calls are started by the invocation handler)
  • Altered the exception handling to be handled by the caller, enhancing the control flow and error management.
  • Created a companion class to handle the implementation of createCallableProxy (that would have been a private method in HasRpcSupport but for now we have tp support Java 8).
  • Conducted refactoring on the InvocationHandler to improve its overall structure and readability.

@javier-godoy javier-godoy requested a review from paodb June 26, 2023 12:51
@paodb paodb merged commit 7a72ed9 into main Jun 26, 2023
@paodb paodb deleted the refactor branch June 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants