Fix improper mass assignment in account registration#5689
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
christopherholland-workday
requested review from
0xi4o,
HenryHengZJ,
igor-magun-wd and
yau-wd
igor-magun-wd
approved these changes
Feb 6, 2026
Contributor
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a mass assignment vulnerability in the account registration process by implementing an allow-list for user-provided fields. The approach is sound and correctly mitigates the security risk. I've included a couple of suggestions to improve the consistency and readability of the new sanitization logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
yau-wd
approved these changes
Feb 12, 2026
vellanki-santhosh
pushed a commit
to vellanki-santhosh/Flowise
that referenced
this pull request
Feb 17, 2026
* Sanitize account information during registration * Fix Improper Mass Assignment in Account Registration * Update account.service.ts * Fix improper mass assignment in account registration * Fix improper mass assignment in account registration * Update packages/server/src/enterprise/controllers/account.controller.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update packages/server/src/enterprise/controllers/account.controller.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * fix(account.controller.ts): remove additional } * chore(organization/index.jsx): remove hardcoded user type pro from organization setup --------- Co-authored-by: yau-wd <yau.ong@workday.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix improper mass assignment in account registration by creating an allow-list of fields that can be copied over, while leaving the server-side generated fields to be generated server-side.